PESDLC-1095 Fix and check len limits when creating shell #17700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
savex
force-pushed
the
PESDLC-1095-priv-shell-name-len
branch
from
3d4cda9
to
99273b1
Compare
StephanDollberg
approved these changes
Apr 8, 2024
| if len(self.pod_name) > 63: | ||
| # Assume that our added chars broke the limit | ||
| # Cut them to fit | ||
| self.pod_name = self.pod_name[:63] |
There was a problem hiding this comment.
This is just a pod name we make up right? So truncating it isn't really an issue.
There was a problem hiding this comment.
Yes,it is just a pod name to find it if someone really wants to.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When creating pod in GKE long suffixes braking the limit of 63 chars enforced by K8s.
This shortens the name and adds a check for the future
Backports Required
Release Notes