Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CORE-1705 rptest: filter abort strings from GCP headers #17705

Merged
merged 1 commit into from
Apr 9, 2024

Conversation

andrwng
Copy link
Contributor

@andrwng andrwng commented Apr 9, 2024

WARN  2024-01-09 10:35:44,813 [shard 1:au  ] s3 - s3_client.cc:865 - S3 DeleteObject request failed: Not Found [X-GUploader-UploadID: ABPtcPrc00gQJdiBKftrKBkHq7lfgurC3j5DPPe1b4TgpjlI0EbSEGVEioXFhqISUy5IrVWlHOeZ94krXQ];[Content-Type: application/xml; charset=UTF-8];[Content-Length: 279];[Vary: Origin];[Date: Tue, 09 Jan 2024 10:35:44 GMT];[Expires: Tue, 09 Jan 2024 10:35:44 GMT];[Cache-Control: private, max-age=0];[Server: UploadServer];

Here,
ABPtcPrc00gQJdiBKftrKBkHq7lfgurC3j5DPPe1b4TgpjlI0EbSEGVEioXFhqISUy5IrVWlHOeZ94krXQ contains "SEGV", but is coming from GCP. This commit adds handling of such header strings tailored for GCP headers[1].

[1] https://cloud.google.com/storage/docs/xml-api/reference-headers#xguploaderuploadid

Backports Required

  • none - not a bug fix
  • none - this is a backport
  • none - issue does not exist in previous branches
  • none - papercut/not impactful enough to backport
  • v23.3.x
  • v23.2.x

Release Notes

  • none

```
WARN  2024-01-09 10:35:44,813 [shard 1:au  ] s3 - s3_client.cc:865 - S3 DeleteObject request failed: Not Found [X-GUploader-UploadID: ABPtcPrc00gQJdiBKftrKBkHq7lfgurC3j5DPPe1b4TgpjlI0EbSEGVEioXFhqISUy5IrVWlHOeZ94krXQ];[Content-Type: application/xml; charset=UTF-8];[Content-Length: 279];[Vary: Origin];[Date: Tue, 09 Jan 2024 10:35:44 GMT];[Expires: Tue, 09 Jan 2024 10:35:44 GMT];[Cache-Control: private, max-age=0];[Server: UploadServer];
```

Here,
`ABPtcPrc00gQJdiBKftrKBkHq7lfgurC3j5DPPe1b4TgpjlI0EbSEGVEioXFhqISUy5IrVWlHOeZ94krXQ`
contains "SEGV", but is coming from GCP. This commit adds handling of such
header strings tailored for GCP headers[1].

[1] https://cloud.google.com/storage/docs/xml-api/reference-headers#xguploaderuploadid
@andrwng andrwng merged commit a5a7355 into redpanda-data:dev Apr 9, 2024
18 checks passed
@vbotbuildovich
Copy link
Collaborator

/backport v23.3.x

@vbotbuildovich
Copy link
Collaborator

/backport v23.2.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants