Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: wait for partition leaders before querying hwm #17708

Merged
merged 1 commit into from
Apr 10, 2024

Conversation

mmaslankaprv
Copy link
Member

@mmaslankaprv mmaslankaprv commented Apr 9, 2024

In disabling partition test we were not waiting for stable partition leadership but we required the partition high-watermark to be reported. In some cases this lead to an error and made the test unstable.

Fixes: #17223

Backports Required

  • none - not a bug fix
  • none - this is a backport
  • none - issue does not exist in previous branches
  • none - papercut/not impactful enough to backport
  • v23.3.x
  • v23.2.x

Release Notes

  • none

In disabling partition test we were not waiting for stable partition
leadership but we required the partition high-watermark to be reported.
In some cases this lead to an error and made the test unstable.

Fixes: redpanda-data#17223

Signed-off-by: Michał Maślanka <michal@redpanda.com>
@vbotbuildovich
Copy link
Collaborator

@vbotbuildovich
Copy link
Collaborator

new failures in https://buildkite.com/redpanda/redpanda/builds/47565#018ec34c-6901-4193-bf71-6052a636a79b:

"rptest.tests.nodes_decommissioning_test.NodesDecommissioningTest.test_decommissioning_and_upgrade"

@mmaslankaprv
Copy link
Member Author

non related ci-failures

@mmaslankaprv mmaslankaprv reopened this Apr 10, 2024
@mmaslankaprv mmaslankaprv merged commit 0f9bb53 into redpanda-data:dev Apr 10, 2024
16 of 21 checks passed
@vbotbuildovich
Copy link
Collaborator

/backport v23.3.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI Failure (assert get_hwms() == hwms3) in DisablingPartitionsTest.test_disable
3 participants