gtest: set death_test_style=threadsafe #17709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rockwotj
previously approved these changes
Apr 9, 2024
|
Looks like the test fails, there is probably something wrong with the signal handling that seastar has. |
"Aborting" matched subprocess dying of unrelated reasons (and not actually because of the assertion).
Default death test style (fast) forks the test process and runs the test immediately after forking. This does not play well with the seastar environment, leading to hangs and weird errors. Switch to 'threadsafe' style instead that runs the test binary from the beginning in the child process. Fixes (latest incarnation of) redpanda-data#14425
ztlpn
force-pushed
the
gtest-threadsafe-death-tests
branch
from
376ee0d
to
af9f7aa
Compare
No, it started failing because it actually started working :) (previously it "passed" because the subprocess crashed due to unrelated reasons). One caveat is that the child process thinks that it has only one cpu core available (I guess because it inherits thread affinity?) and therefore can fail to start if |
rockwotj
approved these changes
Apr 9, 2024
dotnwat
approved these changes
Apr 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Default death test style (fast) forks the test process and runs the test immediately after forking. This does not play well with the seastar environment, leading to hangs and weird errors. Switch to 'threadsafe' style instead that runs the test binary from the beginning in the child process.
Fixes (latest incarnation of) #14425
Backports Required
Release Notes