Followup/feat/cloud storage compaction metric #17723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
return a struct with the byte-size of the replaced segments and the byte-size for the new segment. useful to monitor change in cloud storage size due to compacted reuploads
keep track in a counter of the result of the _manifest->add() operation, if it's a segment reupload operation. the counter is not persisted, so the value is reset every time the manifest is recreated
vectorized_ntp_archiver_compacted_replaced_bytes
Perform update of the metric after the manifest is uploaded. The intention is to not show in the metrics the value until the manifest is visible in cloud_storage.
monitor vectorized_ntp_archiver_compaction_replaced_bytes, check that it strictly increases if the leader hasn't changed.
|
|
piyushredpanda
closed this pull request by merging all changes
into
redpanda-data:dev
in
c4e9ab2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports Required
Release Notes