Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test/shadow_indexing_compacted_topic_test: factored out rpk.describe_topic #17725

Conversation

andijcr
Copy link
Contributor

@andijcr andijcr commented Apr 10, 2024

decribe_topic can be flaky and does not return elements. This change minimizes the risk by using wait_until

Followup for #17627

Backports Required

  • none - not a bug fix
  • none - this is a backport
  • none - issue does not exist in previous branches
  • none - papercut/not impactful enough to backport
  • v23.3.x
  • v23.2.x

Release Notes

  • none

decribe_topic can be flaky, not returning elements. this change minimize
the risk by using wait_until
@andijcr andijcr requested a review from Lazin April 10, 2024 14:18
@vbotbuildovich
Copy link
Collaborator

new failures in https://buildkite.com/redpanda/redpanda/builds/47610#018ec89e-3e9d-44c0-98ad-b7f62b440db4:

"rptest.tests.cluster_bootstrap_test.ClusterBootstrapUpgrade.test_change_bootstrap_configs_after_upgrade.empty_seed_starts_cluster=True"

@andijcr
Copy link
Contributor Author

andijcr commented Apr 11, 2024

issue is #17736 and a failure with gtest_cluster_cloud_metadata_rpfixture that requires a ticket

Copy link
Member

@dotnwat dotnwat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dotnwat dotnwat merged commit 2b151d4 into redpanda-data:dev Apr 11, 2024
13 of 17 checks passed
@andijcr andijcr deleted the followup/feat/cloud_storage_compaction_metric branch April 11, 2024 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants