Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CORE-2212: test: do not start seastar for --gtest_list_tests #17730

Merged
merged 1 commit into from
Apr 10, 2024

Conversation

dotnwat
Copy link
Member

@dotnwat dotnwat commented Apr 10, 2024

    /*
     * if the test is being passed --gtest_list_tests then do not start Seastar.
     * this is an important optimization for using `gtest_discover_tests`
     * because every test exectuable is queried in parallel, and the result is
     * that listing would timeout or seastar would exhaust some kind of resource
     * like aio-max-nr.
     */

Backports Required

  • none - not a bug fix
  • none - this is a backport
  • none - issue does not exist in previous branches
  • none - papercut/not impactful enough to backport
  • v23.3.x
  • v23.2.x

Release Notes

  • none

@dotnwat dotnwat changed the title test: do not start seastar for --gtest_list_tests MINOR: test: do not start seastar for --gtest_list_tests Apr 10, 2024
Signed-off-by: Noah Watkins <noahwatkins@gmail.com>
@dotnwat dotnwat changed the title MINOR: test: do not start seastar for --gtest_list_tests CORE-2212: test: do not start seastar for --gtest_list_tests Apr 10, 2024
@vbotbuildovich
Copy link
Collaborator

@dotnwat dotnwat merged commit c03f983 into redpanda-data:dev Apr 10, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants