Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dt: allow cleanup.policy config diff in backport #17807

Merged
merged 1 commit into from
Apr 12, 2024

Conversation

pgellert
Copy link
Contributor

The fix for changing the source type of the cleanup.policy config from DYNAMIC_TOPIC_CONFIG to DEFAULT_CONFIG is backported to v23.3.x now, and so we need to relax the check in the test_upgrade_compat test to allow observing this config difference in the backported versions as well.

Relates to: https://redpandadata.atlassian.net/browse/CORE-2205

Backports Required

  • none - not a bug fix
  • none - this is a backport
  • none - issue does not exist in previous branches
  • none - papercut/not impactful enough to backport
  • v23.3.x
  • v23.2.x

Release Notes

  • none

The fix for changing the source type of the cleanup.policy config from
DYNAMIC_TOPIC_CONFIG to DEFAULT_CONFIG is backported to v23.3.x now, and
so we need to relax the check in the test_upgrade_compat test to allow
observing this config difference in the backported versions as well.
Copy link
Member

@oleiman oleiman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@pgellert pgellert merged commit 67d3fd4 into redpanda-data:dev Apr 12, 2024
17 checks passed
@pgellert pgellert deleted the fix-config-backport branch April 12, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants