docs: remove tracking pixels, update to transparent Redpanda logo #17822
Conversation
README.md
Outdated
| [<p align="center"><img src="docs/PANDA_sitting.jpg" alt="redpanda sitting" width="400"/></p>](https://redpanda.com/redpanda) | ||
| <img src="https://static.scarf.sh/a.png?x-pxid=3c187215-e862-4b67-8057-45aa9a779055" /> | ||
| <img src="https://www.google-analytics.com/collect?v=2&tid=G-G8V239NH6H&cid=555&t=event&en=page_view&dp=redpanda-data%2Fredpanda&dt=Redpanda%20GitHub" /> | ||
| [<p align="center"><img src="docs/PANDA_sitting.png" alt="redpanda sitting" width="400"/></p>](https://redpanda.com/redpanda) |
There was a problem hiding this comment.
despite them not working because of caching, did we find out if this were unused and we could remove it?
There was a problem hiding this comment.
I don't think we ever got confirmation, other than the Github Docs indicating as much.
There was a problem hiding this comment.
@c4milo do you know about these trackers? i think you added the GA one? we were thinking about removing them as it's not clear they work in the readme given that github caches the tracker images.
There was a problem hiding this comment.
Inspecting element in a web browser shows that the two tracking pixels are most certainly not pointing back to scarf.sh or google-analytics.com, and instead to camo.githubusercontent.com.
FWIW, the scarf tracking pixel is invisible even in dark mode, and it is the google-analytics pixel that is responsible for the visible period in the README.
There was a problem hiding this comment.
yep. so the question here is not if they work/not, but if they need to be fixed or removed.
There was a problem hiding this comment.
I think we need to wait for an internal resolution (slack) on this before proceeding.
WillemKauf
changed the title
From previous README source, it seems that someone was trying to create a hyperlink to the Redpanda website using our logo. Due to formatting, this hyperlink did not work, and clicking the image would only take you to the Github object for the image. This commit fixes the hyperlink, and clicking the Redpanda logo will now take you to our platform-capabilities site.
README.mdwhich didn't work with Github anyways, and furthermore made our Github page less beautiful in dark mode.This PR removes those tracking pixels.
jpgfile format for thePANDA_sittingimage. In dark mode, this resulted in less than desirable white borders around our logo.This PR removes the
jpgimage, and updates it with a transparentpng.PANDA_sittingimage as a hyperlink to https://redpanda.com/redpanda, but due to formatting clicking this would only take you to the Github object for the image.This PR fixes the hyperlink and clicking the image will now re-direct you to our website correctly!
Backports Required
Release Notes
Improvements
README.mdmore beautiful and functional!