Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ducktape: more robust tinygo downloads #17836

Merged
merged 1 commit into from
Apr 12, 2024

Conversation

rockwotj
Copy link
Contributor

When retrying we re-emit the data to gzip, which breaks gzip encoding.
Stream the data to a file first.

Backports Required

  • none - not a bug fix
  • none - this is a backport
  • none - issue does not exist in previous branches
  • none - papercut/not impactful enough to backport
  • v23.3.x
  • v23.2.x

Release Notes

  • none

When retrying we re-emit the data to gzip, which breaks gzip encoding.
Stream the data to a file first.

Signed-off-by: Tyler Rockwood <rockwood@redpanda.com>
@rockwotj rockwotj requested a review from a team as a code owner April 12, 2024 18:16
@rockwotj rockwotj requested review from andrewhsu, travisdowns and rpdevmp and removed request for a team April 12, 2024 18:16
Copy link
Contributor

@rpdevmp rpdevmp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rockwotj rockwotj merged commit bf101b1 into redpanda-data:dev Apr 12, 2024
16 checks passed
@rockwotj rockwotj deleted the tinygo-download branch April 12, 2024 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants