CORE-2378 id_allocator: do not forward requests beyond first hop #17892
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A tight forward-to-leader loop has been discovered in a test where metadata about leader is out of date: redpanda-data#17873. Instead, we remove the forwarding from the request handler and do it only once on the original invoker. In `id_allocator_frontend::allocate_id` we call `allocate_router::process_or_dispatch` which will do the redirect and retry if the target node returns an error/does not respond. It also has backoff built in. This is a fix very similar to one described in redpanda-data#15953. Fixes redpanda-data#17873
rockwotj
approved these changes
Apr 16, 2024
bharathv
approved these changes
Apr 16, 2024
|
ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/47876#018ee807-b80f-4cc4-9d83-892597bb9f0d ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/47876#018ee807-b815-45d0-a187-0f01c7979ead |
|
Failure: #16198 |
|
/backport v23.3.x |
This was referenced Apr 16, 2024
dotnwat
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A tight forward-to-leader loop has been discovered in a test where metadata about leader is out of date:
#17873.
Instead, we remove the forwarding from the request handler and do it only once on the original invoker. In
id_allocator_frontend::allocate_idwe callallocate_router::process_or_dispatchwhich will do the redirect and retry if the target node returns an error/does not respond. It also has backoff built in.This is a fix very similar to one described in
#15953.
Fixes #17873
Backports Required
Release Notes