Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CORE-2400] kafka/server: Disable quota balancer #17906

Conversation

BenPope
Copy link
Member

@BenPope BenPope commented Apr 16, 2024

v2 was enabled by default in #16441

Running the balancer doesn't do anything other than waste cpu cycles.

Backports Required

  • none - not a bug fix
  • none - this is a backport
  • none - issue does not exist in previous branches
  • none - papercut/not impactful enough to backport
  • v23.3.x
  • v23.2.x

Release Notes

  • none

@BenPope BenPope requested a review from oleiman April 16, 2024 21:49
@BenPope BenPope self-assigned this Apr 16, 2024
v2 was enabled by default in:
redpanda-data#16441

Running the balancer doesn't do anything other
than waste cpu cycles.

Signed-off-by: Ben Pope <ben@redpanda.com>
@BenPope BenPope force-pushed the throughput_shared_token_bucket_disable_snc branch from 16cda05 to e0ba45e Compare April 16, 2024 21:50
@BenPope BenPope changed the title kafka/server: Disable quota balancer [CORE-2400] kafka/server: Disable quota balancer Apr 16, 2024
Copy link
Member

@dotnwat dotnwat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it intended to always be disabled from now on? if so perhaps its better to deprecate?

@BenPope
Copy link
Member Author

BenPope commented Apr 16, 2024

is it intended to always be disabled from now on? if so perhaps its better to deprecate?

I plan to delete the old implementation

But I also plan to backport this PR, but not the delete.

@vbotbuildovich
Copy link
Collaborator

vbotbuildovich commented Apr 17, 2024

Copy link
Member

@oleiman oleiman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0️⃣

@piyushredpanda piyushredpanda merged commit 8cc2fe1 into redpanda-data:dev Apr 22, 2024
15 of 18 checks passed
@vbotbuildovich
Copy link
Collaborator

/backport v23.3.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants