CORE-2388 rptest: remove node from started list after kill #17913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/47926#018eec41-9e8f-48d5-bce5-84d1690bf62f ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/47964#018eed50-35ab-4e2f-9967-d8e6045e6f97 |
bharathv
reviewed
Apr 17, 2024
We have a wrapper RedpandaService.wait_until which is used to wait for conditions as long as the cluster is "healthy". Healthy is defined as all "started nodes" being up. When we call signal_redpanda to kill a particular node on purpose. In this case, we also need to remove the node from the started nodes list otherwise the above check will trip thinking that a node is crashed or something similar. I have tried to add this logic inside the signal_redpanda method in [redpanda-data#17889][1] but discovered that there are tests which rely on the existing behavior already. @bharathv noticed that stop_node can be used instead so this PR does that. Fixes redpanda-data#17886 [1]: redpanda-data#17889
nvartolomei
force-pushed
the
nv/remove-started-node
branch
from
37d5dce
to
d3dc974
Compare
bharathv
approved these changes
Apr 17, 2024
dotnwat
approved these changes
Apr 17, 2024
dotnwat
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a wrapper RedpandaService.wait_until which is used to wait for
conditions as long as the cluster is "healthy". Healthy is defined as
all "started nodes" being up.
When we call signal_redpanda to kill a particular node on purpose. In
this case, we also need to remove the node from the started nodes list
otherwise the above check will trip thinking that a node is crashed or
something similar.
I have tried to add this logic inside the signal_redpanda method in
#17889 but discovered that there are tests which rely on the
existing behavior already.
@bharathv noticed that stop_node can be used instead so this PR does
that.
Fixes #17886
Backports Required
Release Notes