c/controller_backend: don't require cur_operation after reconciliation step #17926
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n step In case when we need to wait before shard_placement_table and topic_table become consistent (i.e. the expected log_revision of an ntp is the same), the concept of "current operation" doesn't make much sense because we may not yet know what we are required to do for reconciliation. Therefore we shouldn't require the current_operation to be non-null after a reconciliation step returns an error.
Previously ntp_table and shard_placement_table were updated sequentially, which is not necessarily true for real executions (for instance shard_placement_table on shard 1 can get updated after topic_table was updated on shard 0 but before it got updated on shard 1). Instead, trigger shard_placement_table update after ntp_table update on shard 0, which resembles real execution more.
|
ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/47960#018eed34-577c-4239-9a71-13582433f398 |
mmaslankaprv
approved these changes
Apr 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case when we need to wait before shard_placement_table and topic_table become consistent (i.e. the expected log_revision of an ntp is the same), the concept of "current operation" doesn't make much sense because we may not yet know what we are required to do for reconciliation. Therefore we shouldn't require the current_operation to be non-null after a reconciliation step returns an error.
Backports Required
Release Notes