cleanup: clang 18 fixes #17949
Merged
cleanup: clang 18 fixes #17949
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This check is optin and the docs say to disable if you use enums as bitflags (which we do), so disable this check. Signed-off-by: Tyler Rockwood <rockwood@redpanda.com>
Fix up new findings in clang-18 Signed-off-by: Tyler Rockwood <rockwood@redpanda.com>
This warning fails because we use enums as flags and the bitwise combination of flags can be an "invalid" enum value. Disable the warning. Signed-off-by: Tyler Rockwood <rockwood@redpanda.com>
Signed-off-by: Tyler Rockwood <rockwood@redpanda.com>
rockwotj
requested review from
hobbseltoff and
dotnwat
and removed request for
a team
dotnwat
approved these changes
Apr 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A variety of fixes so the OSS builds cleanly on clang-18
Backports Required
Release Notes