transform: start loading VMs after logs are started #17965
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oleiman
previously approved these changes
Apr 19, 2024
Let's make sure we start the log manager before we start loading Wasm VMs. Probably not going to cause an issue, but just to be safe. Signed-off-by: Tyler Rockwood <rockwood@redpanda.com>
rockwotj
force-pushed
the
start-wasm-logger-first
branch
from
314beb2
to
c5417c4
Compare
Good question, the order should be reversed between the two (like destructor order), so I've flipped the startup to match the stop method, as the stop method looks more correct for me |
|
CI failed due to infra issues |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's make sure we start the log manager before we start loading Wasm
VMs. Probably not going to cause an issue, but just to be safe.
Backports Required
Release Notes