fetch: Avoid formatting client ip and port for each partition #17967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StephanDollberg
force-pushed
the
stephan/fetch-plan-dont-format-for-each-partition
branch
from
f84f769
to
3fce339
Compare
|
"Hide whitespace" or going commit-by-commit recommended. Not sure why clang-format suddenly thinks it needs to reformat everything. |
Avoid a copy of the fetch_config which contains a string so this avoids an extra allocation.
Putting this into a separate commit. For whatever reason clang-format goes berzerk here and reformats that whole lambda.
We were formatting the ip and port of the client for each partition in the fetch plan. This is unneeded as it obviously doesn't change by topic or partition. The formatting is fairly expensive and amounts for ~2-3% of total reactor time in a high partition count scenario. This could be further optimized by moving the formatted version to the connection context to avoid having this copy alive many times but that's a bit larger change for another PR.
StephanDollberg
force-pushed
the
stephan/fetch-plan-dont-format-for-each-partition
branch
from
3fce339
to
ab894d4
Compare
This is merge skew and is fixed in upstream/dev so nothing to worry about. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were formatting the ip and port of the client for each partition in
the fetch plan. This is unneeded as it obviously doesn't change by topic
or partition.
The formatting is fairly expensive and amounts for ~2-3% of total
reactor time in a high partition count scenario.
This could be further optimized by moving the formatted version to the
connection context to avoid having this copy alive many times but that's
a bit larger change for another PR.
Before:
After:
Backports Required
Release Notes