Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CORE-2451 cloud_storage_clients/abs_clients: fix iterator check #17969

Merged
merged 1 commit into from
Apr 20, 2024

Conversation

andijcr
Copy link
Contributor

@andijcr andijcr commented Apr 19, 2024

fixed a missing error_code_it != headers.end() check

Normally on Azure, the HTTP 400 error response has a x-ms-error-code header, so headers.find("x-ms-error-code")->value() is well-behaved, but it's not safe to not check the iterator before accessing it.

Fixes CORE-2451

Backports Required

  • none - not a bug fix
  • none - this is a backport
  • none - issue does not exist in previous branches
  • none - papercut/not impactful enough to backport
  • v23.3.x
  • v23.2.x

Release Notes

  • none

@andijcr
Copy link
Contributor Author

andijcr commented Apr 19, 2024

manually tested this matrix of config

cloud_storage_credentials_source = [azure_vm_instance_metadata]
cloud_storage_azure_hierarchical_namespace_enabled = [None, True, False]
azure container backend =[with HNS, without HNS]

some of the combinations result in ERRORS:

cloud_storage_azure_hierarchical_namespace_enabled = True, azure container backend = without HNS
cloud_storage_azure_hierarchical_namespace_enabled = False, azure container backend = with HNS

and redpanda correctly handles the exceptions without crashing

tested successfully with missing x-ms-error-code with dev...andijcr:redpanda:followup/aks_oidc_support

@andijcr
Copy link
Contributor Author

andijcr commented Apr 19, 2024

2 Known failures: #17176
#13841

@dotnwat dotnwat merged commit abce169 into redpanda-data:dev Apr 20, 2024
15 of 18 checks passed
@andijcr andijcr deleted the fix/abs_client_set_expiry_test branch April 22, 2024 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants