[CORE-2461] c/topics: use topic table revision to detect changes in generator #17975
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmaslankaprv
changed the title
ztlpn
previously approved these changes
Apr 22, 2024
Topic table partition generator is a simple helper to asynchronously iterate over a topic table which may have a lot of elements. The generator validates if `topic_table` changed while the loop yield for the other tasks. The check was incorrect as it was validating the topic table revision which is updated after the snapshot is applied. Fixed the issue by validating it `_topics_map_revision` changed during the scheduling point. Fixes: #core-internal/1259 Signed-off-by: Michał Maślanka <michal@redpanda.com>
mmaslankaprv
force-pushed
the
fix-internal-1259
branch
from
23c4497
to
14726e2
Compare
ztlpn
approved these changes
Apr 22, 2024
|
/backport v23.3.x |
|
/backport v23.2.x |
This was referenced Apr 22, 2024
Merged
|
Feels like something really simple like this might be source of the segfault we've been seeing in the partition balancer, which also has a lot of the safe-iteration-revision logics? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Topic table partition generator is a simple helper to asynchronously iterate over a topic table which may have a lot of elements. The generator validates if
topic_tablechanged while the loop yield for the other tasks. The check was incorrect as it was validating the topic table revision which is updated after the snapshot is applied.Fixed the issue by validating it
_topics_map_revisionchanged during the scheduling point.Fixes: #core-internal/1259
Backports Required
Release Notes
Bug Fixes