Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v24.1.x] CORE-2627 fix AZURE_AUTHORITY_HOST parsing in azure_ask_refresh_impl #18042

Merged
merged 3 commits into from
Apr 25, 2024
Merged

[v24.1.x] CORE-2627 fix AZURE_AUTHORITY_HOST parsing in azure_ask_refresh_impl #18042

merged 3 commits into from
Apr 25, 2024

Conversation

vbotbuildovich
Copy link
Collaborator

Backport of PR #18035

@andijcr @vbotbuildovich
cloud_roles/azure_aks_refresh_impl: parse AZURE_AUTHORITY_HOST as url
7ea3539 
use ada::parse to parse the content of AZURE_AUTHORITY_HOST. if it
fails, assume it's an hostname

(cherry picked from commit 038022e)
@andijcr @vbotbuildovich
cloud_roles/role_client_tests: test aks AZURE_AUTHORITY_HOST parsing
1283f3e 
verify the ability to parse an hostname or a more complete url

(cherry picked from commit dad8d8c)
@vbotbuildovich vbotbuildovich added this to the v24.1.x-next milestone Apr 24, 2024
@vbotbuildovich vbotbuildovich added the kind/backport PRs targeting a stable branch label Apr 24, 2024
@andijcr
cloud_roles/role_clients_tests: use SEASTAR_THREAD_TEST_CASE
b26ed31 
use of setenv under seastar requires to run under a initialized seastar
context, since internal memory management functions will be called
@andijcr andijcr mentioned this pull request Apr 24, 2024
Merged
7 tasks
andijcr
andijcr approved these changes Apr 24, 2024
View reviewed changes
Copy link
Contributor

@andijcr andijcr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#18052

included this test fix into this pr

@andijcr andijcr requested a review from dotnwat April 24, 2024 18:06
@andijcr
Copy link
Contributor

andijcr commented Apr 24, 2024

kafka_server_rpfixture is failing but i can't see the reason in the log

@piyushredpanda piyushredpanda merged commit bce996a into redpanda-data:v24.1.x Apr 25, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andijcr andijcr andijcr approved these changes

@dotnwat dotnwat Awaiting requested review from dotnwat

Assignees
No one assigned
Labels
area/redpanda kind/backport PRs targeting a stable branch
Projects
None yet
Milestone
24.1.1-GA
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vbotbuildovich @andijcr @piyushredpanda