[v24.1.x] Fixes for wait_ms cpu profiler mode #18141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently we would only enable the profiler on the shard handling the Admin API request. Fix it such that we would actually get samples from all shards. (cherry picked from commit 937f6ea)
The timer to collect traces from within seastar only fires every ~128 * `sample_period`. With default settings that's only every 13 seconds so `wait_ms` times like 5 seconds or 18 seconds wouldn't really work as expected. Hence explicitly poll samples from seastar before collecting them all and returning them from `wait_ms`. (cherry picked from commit ab725e5)
StephanDollberg
approved these changes
Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of PR #18089