[v24.1.x] controller_backend: prevent busy-looping when removing partitions #18216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/ci-repeat |
To better mimic concurrency structure of the real shard_balancer, introduce the shard_assigner component to the stress test that is responsible for modifying assignments in the shard placement table. (cherry picked from commit e969333) Conflicts: src/v/cluster/tests/shard_placement_table_test.cc
Previously, in the interval between topic_table update and shard_placement_table update, controller_backend busy-looped by "successfully removing" a partition that already wasn't there (the only thing remaining was the assignment marker that remained until the shard_placement_table update fully completed). Return a wait_for_target_update error instead that will put the reconciliation fiber to sleep. (cherry picked from commit 7bae9ef)
…ping (cherry picked from commit dbf88ca) Conflicts: src/v/cluster/tests/shard_placement_table_test.cc
If reconciliation was successful, but another notification arrived in the meantime, we don't have to exit try_reconcile_ntp loop (and therefore sleep before the next attempt), we can proceed to reconciling again right away. (cherry picked from commit e312753) Conflicts: src/v/cluster/controller_backend.cc
|
/ci-repeat |
|
test errors unrelated (#18032 and something similar to #14062 related to the fact that we sent a reconfiguration request to a node that was being restarted). |
piyushredpanda
approved these changes
May 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of PR #18157