offline_log_viewer: fix get_control_record_type #18246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnwat
reviewed
May 7, 2024
| @@ -82,7 +90,7 @@ def decode_record(batch, header, record): | |||
| is_ctrl = attrs["control_batch"] | |||
| is_tx_ctrl = is_txn and is_ctrl | |||
| if is_tx_ctrl: | |||
| record_dict["type"] = self.get_control_record_type(record.key) | |||
| record_dict["type"] = get_control_record_type(record.key) | |||
There was a problem hiding this comment.
did you also want to remove the duplicate function get_control_record_type in KafkaLog below?
There was a problem hiding this comment.
yikes.. I swear I removed it, maybe forgot to commit those changes.. anyway fixed it..
Also added a little regression test for future, had to adjust printing logic to print a wellformed json to stdout.
Noticed this was broken while parsing some logs. Added a little regression test for the parsing
|
will re-request reviews once tests pass.. these OLV script changes usually break existing tests |
nvartolomei
approved these changes
May 8, 2024
|
Failure |
|
/backport v24.1.x |
|
/backport v23.3.x |
This was referenced May 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed this was broken while parsing some logs.
Backports Required
Release Notes