-
Notifications
You must be signed in to change notification settings - Fork 559
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CORE-526 k/configs: dont override topic-level cleanup policy #18284
base: dev
Are you sure you want to change the base?
CORE-526 k/configs: dont override topic-level cleanup policy #18284
Commits on Jul 1, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 9a3f846 - Browse repository at this point
Copy the full SHA 9a3f846View commit details -
k/configs: revert broken fix for cleanup.policy
The first attempt at fixing the way to report cleanup.policy was incorrect, because it meant that we reported the config as DEFAULT_CONFIG even if the config was explicitly set but to the cluster-default value. Instead, in this case, we want to report this as a DYNAMIC_TOPIC_CONFIG. We can do this now since we stopped setting the cleanup.policy value explicitly for each topic. Furthermore, the compat tests was simplified because now there are 2 separate fix attepts deployed at multiple redpanda versions, so to keep the test sane, we just ignore the diff until a version (24.2.1) where we know that this version will contain the fixes and all following version we might compare against also contains the fixes. Lastly, the change to the DescribeTopicConfigs ducktape test was also reverted to correctly report the cleanup.policy as DYNAMIC_TOPIC_CONFIG when this was explicitly specified on the topic creation request.
Configuration menu - View commit details
-
Copy full SHA for 6a26dba - Browse repository at this point
Copy the full SHA 6a26dbaView commit details -
Revert "k/alter_configs: use default for cleanup policy"
This reverts commit 261dc93.
Configuration menu - View commit details
-
Copy full SHA for f2bea7f - Browse repository at this point
Copy the full SHA f2bea7fView commit details
Commits on Jul 3, 2024
-
model: add cleanup_policy_bitflags helpers
Pure refactor. Adds helpers to check if compaction or deletion are set in the cleanup policy flags.
Configuration menu - View commit details
-
Copy full SHA for 100a7f5 - Browse repository at this point
Copy the full SHA 100a7f5View commit details -
c/ntp_config: fall back to cluster cleanup policy
This changes all uses of `ntp_config::is_compacted` and `ntp_config::is_collectible` to fall back to the cluster-wide default config `log_cleanup_policy`.
Configuration menu - View commit details
-
Copy full SHA for 42bc50a - Browse repository at this point
Copy the full SHA 42bc50aView commit details -
c/partition_rec_mgr: use default cleanup policy
Since it is no longer the case that all topics have a topic-level override for the cleanup policy, we fall back to using the cluster-level default cleanup policy when the topic-level override is not set during the partition recovery process.
Configuration menu - View commit details
-
Copy full SHA for 0ee76da - Browse repository at this point
Copy the full SHA 0ee76daView commit details -
c/partition: fix read replica config change
This fixes a bug in the handling of archiver restarts when the read replica topic config changes. Previously the archiver would incorrectly restart on every topic config change if "read_replica" was set to `std::optional<bool>(false)`.
Configuration menu - View commit details
-
Copy full SHA for aff7085 - Browse repository at this point
Copy the full SHA aff7085View commit details -
c/partition: refactor archiver restarts
Pure refactor except that the log messages emitted when cloud storage needs to be restart change. The message emitted now states the reason for restarting cloud storage instead of printing the old and new ntp configs.
Configuration menu - View commit details
-
Copy full SHA for c8a44f7 - Browse repository at this point
Copy the full SHA c8a44f7View commit details
Commits on Jul 5, 2024
-
storage: refactor compaction update interface
Pure refactor, no behaviour change intended. This changes the partition-raft-log interface to decouple topic-level config overrides and changes to compaction. This allows calling `log::notify_compaction_update` independently from `log::set_overrides` whenever `log_cleanup_policy` changes in the follow up commit.
Configuration menu - View commit details
-
Copy full SHA for 3bdda1a - Browse repository at this point
Copy the full SHA 3bdda1aView commit details -
storage: watch for
log_cleanup_policy
changesNow that the cleanup policy is not always set on the topic-level overrides, we need to watch for changes to the `log_cleanup_policy` config and react to that by: * Restarting the archiver if compaction changes * (Un)marking the segments for compaction if compaction changes
Configuration menu - View commit details
-
Copy full SHA for 5176a08 - Browse repository at this point
Copy the full SHA 5176a08View commit details -
dt/archival: test restart on compaction changes
This adds tests to verify that archiver is restarted whenever there are changes to the compaction configs, either at the cluster-level defaults or at the topic-level overrides.
Configuration menu - View commit details
-
Copy full SHA for c7faff3 - Browse repository at this point
Copy the full SHA c7faff3View commit details