Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CORE-2708 - chore: fix open source CI build #18330

Closed
wants to merge 2 commits into from

Conversation

pgellert
Copy link
Contributor

@pgellert pgellert commented May 9, 2024

The open source build is currently failing because we need to upgrade the seastar version used by the open source build to match what we use in the vtools-based build.

Also, another error in the open source build is that it tries to use golang version 1.21 to build kreq-gen because that is what is available on ubuntu:mantic and fedora:38. Unfortunately, we can't upgrade to the newer OS yet because that would upgrade clang to clang-18 as well, which we are not ready for. So for the meantime, I have reverted to using go v1.21 for kreq-gen.

Fixes https://redpandadata.atlassian.net/browse/CORE-2708

Failing OSS builds: https://github.com/redpanda-data/redpanda/actions/workflows/build-redpanda.yml

Backports Required

  • none - not a bug fix
  • none - this is a backport
  • none - issue does not exist in previous branches
  • none - papercut/not impactful enough to backport
  • v24.1.x
  • v23.3.x
  • v23.2.x

Release Notes

  • none

This is needed to fix the failing open source build. Until we upgrade to
newer OS versions of ubuntu and fedora, we need to stick to v1.21
because the version of golang installed by install-dependencies.sh is
1.21 on both fedora:38 and ubuntu:mantic.
@pgellert pgellert requested review from dotnwat, graphcareful and a team May 9, 2024 16:25
@pgellert pgellert self-assigned this May 9, 2024
@pgellert pgellert requested review from BenPope and a team as code owners May 9, 2024 16:25
@pgellert pgellert requested review from andrewhsu and removed request for a team May 9, 2024 16:25
@vbotbuildovich
Copy link
Collaborator

vbotbuildovich commented May 9, 2024

Copy link
Member

@oleiman oleiman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. so i understand - go 1.21 was the minimum needed for the changes to kreq-gen, and we went to 1.22 because we could?

Copy link
Contributor

@graphcareful graphcareful left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vbotbuildovich
Copy link
Collaborator

new failures in https://buildkite.com/redpanda/redpanda/builds/48904#018f5f2f-f74e-4aac-9ff7-74b1f512ef82:

"rptest.tests.e2e_iam_role_test.AWSRoleFetchTests.test_write"

Copy link
Member

@BenPope BenPope left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pgellert
Copy link
Contributor Author

pgellert commented May 10, 2024

lgtm. so i understand - go 1.21 was the minimum needed for the changes to kreq-gen, and we went to 1.22 because we could?

It's more that I updated the go version without a strict requirement to update (so there's not minimum needed). But go 1.21 is the highest we can go for now. I went with 1.22 initially because that was what rpk had and what vtools installed.

@pgellert
Copy link
Contributor Author

pgellert commented May 10, 2024

Closing in favour of #18390 because after testing I had to push more changes. I can only run the oss build on branches of the repo, so I pushed my changes to this new internal branch instead.

@pgellert pgellert closed this May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants