-
Notifications
You must be signed in to change notification settings - Fork 564
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CORE-2708 - chore: fix open source CI build #18330
Conversation
This is needed to fix the failing open source build. Until we upgrade to newer OS versions of ubuntu and fedora, we need to stick to v1.21 because the version of golang installed by install-dependencies.sh is 1.21 on both fedora:38 and ubuntu:mantic.
ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/48895#018f5e68-3467-4c14-8061-02b98a9ebe85 ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/48895#018f5e68-3461-48d3-aac8-5b3f0af77d64 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. so i understand - go 1.21
was the minimum needed for the changes to kreq-gen
, and we went to 1.22
because we could?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
new failures in https://buildkite.com/redpanda/redpanda/builds/48904#018f5f2f-f74e-4aac-9ff7-74b1f512ef82:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
It's more that I updated the go version without a strict requirement to update (so there's not minimum needed). But |
Closing in favour of #18390 because after testing I had to push more changes. I can only run the oss build on branches of the repo, so I pushed my changes to this new internal branch instead. |
The open source build is currently failing because we need to upgrade the seastar version used by the open source build to match what we use in the vtools-based build.
Also, another error in the open source build is that it tries to use golang version 1.21 to build kreq-gen because that is what is available on ubuntu:mantic and fedora:38. Unfortunately, we can't upgrade to the newer OS yet because that would upgrade clang to clang-18 as well, which we are not ready for. So for the meantime, I have reverted to using go v1.21 for kreq-gen.
Fixes https://redpandadata.atlassian.net/browse/CORE-2708
Failing OSS builds: https://github.com/redpanda-data/redpanda/actions/workflows/build-redpanda.yml
Backports Required
Release Notes