Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dt] add retries to remote curl call #18387

Merged
merged 1 commit into from
May 10, 2024
Merged

[dt] add retries to remote curl call #18387

merged 1 commit into from
May 10, 2024

Conversation

jackietung-redpanda
Copy link
Contributor

@jackietung-redpanda jackietung-redpanda commented May 9, 2024

During RP installation within Ducktape tests, we use curl to download RP from S3. This can fail due to intermittent network issues. Adding retries is a good idea to prevent inevitable test flakes.

Release Notes

  • none

Backports Required

  • none - not a bug fix
  • none - this is a backport
  • none - issue does not exist in previous branches
  • none - papercut/not impactful enough to backport
  • v24.1.x
  • v23.3.x
  • v23.2.x

@CLAassistant
Copy link

CLAassistant commented May 9, 2024

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link
Contributor

@gousteris gousteris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dotnwat dotnwat merged commit 0cc4a56 into dev May 10, 2024
16 of 19 checks passed
@dotnwat dotnwat deleted the jackie-dt-retries branch May 10, 2024 19:07
@vbotbuildovich
Copy link
Collaborator

/backport v24.1.x

@vbotbuildovich
Copy link
Collaborator

/backport v23.3.x

@vbotbuildovich
Copy link
Collaborator

/backport v23.2.x

@vbotbuildovich
Copy link
Collaborator

Failed to create a backport PR to v23.2.x branch. I tried:

git remote add upstream https://github.com/redpanda-data/redpanda.git
git fetch --all
git checkout -b backport-pr-18387-v23.2.x-954 remotes/upstream/v23.2.x
git cherry-pick -x f236b110b357f8317a2920c0630178e9fa6ff420

Workflow run logs.

@vbotbuildovich
Copy link
Collaborator

Failed to create a backport PR to v23.3.x branch. I tried:

git remote add upstream https://github.com/redpanda-data/redpanda.git
git fetch --all
git checkout -b backport-pr-18387-v23.3.x-876 remotes/upstream/v23.3.x
git cherry-pick -x f236b110b357f8317a2920c0630178e9fa6ff420

Workflow run logs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants