[v23.3.x] Fixed possible log discrepancy when using forced reconfiguration #18855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed the way how Redpanda raft handles force reconfigurations. Instead of appending configuration to the log we keep a volatile in memory override for the configuration that was forced. The override is dropped whenever a node receives different configuration. This approach allow us to avoid discrepancies as not data are appended to the log without the active leader. Signed-off-by: Michał Maślanka <michal@redpanda.com> (cherry picked from commit 01bef11)
mmaslankaprv
force-pushed
the
vbotbuildovich/backport-18153-v23.3.x-399
branch
2 times, most recently
from
e5cfb8a
to
929a2ee
Compare
Added a check in `cluster::controller_backend` validating if configuration override has been reset before trying to finish the update. The dependency is already there as backend is waiting for the leader to be elected and confirmed however it is easier to read when the dependency is explicitly expressed Signed-off-by: Michał Maślanka <michal@redpanda.com> (cherry picked from commit ac67ca3)
mmaslankaprv
force-pushed
the
vbotbuildovich/backport-18153-v23.3.x-399
branch
from
929a2ee
to
e2ef789
Compare
ztlpn
approved these changes
Jun 11, 2024
|
/ci-repeat 1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of PR #18153