Backport #3233 #3248
Merged
Backport #3233 #3248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, when both flags (redpanda.remoe.read and redpanda.remote.write) are set and alter-config drops one both are dropped. After the fix flags can be dropped individually. Thic commit also adds a regression ducktape test. (cherry picked from commit 6c06dc9)
Add two new cluster level configs: - cloud_storage_enable_remote_read - cloud_storage_enable_remote_write The parameters can be used to enable shadow indexing (both archival uploads and shadow indexing fetch) for all topics. The topic level configurations (redpanda.remote.read and redpanda.remote.write) act as an override for the global parameters. The overrides can be used to enable shadow indexing (or its part) if shadow indexing is disabled in the config. And also the topic level overrides can be used to disabled shadow indexing for the topic if shadow indexing is enabled in the config. (cherry picked from commit 1838db9)
Add alter-config test that checks that the topic is described correctly if shadow indexing is enabled globally. Also, the test checks if shadow indexing can be disabled for a topic if it's enabled globally. Also, update e2e_shadow_indexing_test to use global settings instead of per topic configurations. This verifies that shadow indexing can be enabled globally. (cherry picked from commit 7bf31aa)
The test verifies that the flags can be dropped. (cherry picked from commit f1bd459)
Lazin
requested review from
dotnwat,
ivotron,
LenaAn,
mmaslankaprv,
NyaliaLui,
VadimPlh and
ztlpn
as code owners
dotnwat
approved these changes
Dec 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR back ports #3233 - Add global shadow indexing flags.