21.11.X: k8s: fix bug reconciling clusters with fixed nodeport #3281
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cover letter
The nodeport service when
nodePort
field provided behaves a bit differently and repeated create on the same resource does not return createifnotexists error but rather an allocation error. so because of that, after the external service gets created after first run of the reconciliation loop, it keeps failing with the nodeport allocated error. The fix is to switch toget-or-create
method that creates only if GET call did not succeed.Fixes #3263
Release notes
Improvements
k8s: fixed bug with nodeport handling for clusters that have external connectivity with fixed port