Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v21.11.x] bytes: impose max chunk size on ss_next_allocation_size #3472

Merged
merged 1 commit into from
Jan 14, 2022

Conversation

jcsp
Copy link
Contributor

@jcsp jcsp commented Jan 13, 2022

Cover letter

Backport of #3435

Fixes: #3428

Release notes

Improvements

  • Improved stability when doing large kafka fetch requests under low memory conditions.

This is the helper for iobuf_copy, that previously would
attempt to allocate huge contiguous extents when copying
large iobufs.

Make it respect the same max_chunk_size as iobuf
append/reserve operations, to avoid bad_allocs when
copying large buffers under memory pressure.

Fixes: redpanda-data#3428

Signed-off-by: John Spray <jcs@vectorized.io>
(cherry picked from commit a9a7a3e)
Copy link
Member

@travisdowns travisdowns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dotnwat dotnwat merged commit e947c28 into redpanda-data:v21.11.x Jan 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants