[v21.11.x] Backport "Persisted_stm: fix sync timing out in case of acks=1" #4289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, if the user produced with acks=1, persisted_stm::sync always
timed out because we tried to wait until commit_index reached the
current dirty offset and, even though we flushed on the leader, the
followers didn't flush and commit_index didn't move.
Instead, now we sync only up to the last offset before the start of the
current term. This upholds the contract of persisted_stm::sync ("it waits
until the state machine is caught up with all the events written by the
previous leaders") and we don't have to do any additional flushes
because after election the new leader replicates the configuration batch
and always does it with acks=-1.
(cherry picked from commit 8737bde)
(cherry picked from commit 7f31af7)
ztlpn
requested review from
dotnwat,
ivotron,
NyaliaLui and
rystsov
as code owners
ivotron
approved these changes
Apr 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cover letter
Backport #4277 to v21.11.x
Fixes #4288