-
Notifications
You must be signed in to change notification settings - Fork 552
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[backport] admin_api: Added reset/get leaders_table requests #4303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This request is used to refresh leaders info on node User can invoke it by using admin api On some cases leaders_table can not be updated long time So client request can be failed in this cases. New request allows us force leaders table by hand, after it shard should be refresh all info about leaders. After reset leaders info, metadata responce will not contain leaders for all partition during short period of time ~150ms. heartbits delay or leader notification delay. (cherry picked from commit aae98ed)
(cherry picked from commit 44db376)
(cherry picked from commit d2a500b)
VadimPlh
requested review from
dotnwat,
ivotron,
NyaliaLui,
mmaslankaprv and
ztlpn
as code owners
April 16, 2022 11:49
ivotron
reviewed
Apr 19, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this seems to be breaking all steps, expect the k8s-helm one
(cherry picked from commit fcd5acd)
This debug API to understand what current node thinks about leaders. User can execute it by usung admin API. Becasue it is debug request we only execute it on one core, without merging ans. (cherry picked from commit 8a84ba8)
(cherry picked from commit e26ea3e)
(cherry picked from commit c93f730)
(cherry picked from commit f9ace4d)
(cherry picked from commit fea4405)
(cherry picked from commit aef23b6)
mmaslankaprv
approved these changes
Apr 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cover letter
Backport #4259
Backport #4237
Fixes #4302
Release notes