[v21.11.14] backport: do not step down when replicating configuration failed #4349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In redpanda leader replicates a configuration after successful vote round. Configuration replication success isn't required for the node to hold the leadership. In some scenarios, when majority of followers are behind the leader and need recovery, configuration replication may timeout. This doesn't mean however that leader should stepdown. In order to maintain leadership it should continue recovering followers and step down only if there are no heartbeat responses from majority of the followers. Signed-off-by: Michal Maslanka <michal@vectorized.io> (cherry picked from commit dea6cfb)
mmaslankaprv
requested review from
ztlpn,
jcsp,
VadimPlh and
rystsov
as code owners
ztlpn
approved these changes
Apr 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In redpanda leader replicates a configuration after successful vote
round. Configuration replication success isn't required for the node to
hold the leadership.
In some scenarios, when majority of followers are behind the leader and
need recovery, configuration replication may timeout. This doesn't mean
however that leader should stepdown. In order to maintain leadership it
should continue recovering followers and step down only if there are no
heartbeat responses from majority of the followers.
Backport of PR #4342
Fixes #4353