[v22.2.x] Partition balancer full_nodes test: wait until the balancer is stable #6587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Waiting for greater than 70% average disk usage is a bit flaky because of changing distribution of fallocated chunks among segments. Instead we simply wait for the producer to finish. If insufficient data will be produced to have a meaningful test run, we'll fail at the next stage where we wait for the "stalled" balancer status. (cherry picked from commit fa574e1)
Sometimes the node can violate the disk limit again even after the balancer reported the ready status (e.g. the leader balancer initiated a leadership transfer that resulted in a segment roll and, consequently, fallocation). To avoid this we check that the ready status has been stable for a few balancer ticks. This will fix the disk usage assertion fails and will allow us to check that the balancer does not exhibit undesirable flaps. Fixes redpanda-data#5884 (cherry picked from commit aebcd4b)
(cherry picked from commit 7b3d8c5)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport from pull request: #6540.
Fixes #6586,