raft: amend error code when leadership transfer can't proceed due to recovery #7297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When do_transfer_leadersip(), if a follower is still not caught up after prepare_transfer_leadership() is done, a `timeout` was returned. However it's not really a timeout, it's a flap (we thought recovery was done but it's not). This commit changes it to `exponential_backoff` so that admin API would return a 503 (plz retry) for that rather than a 504 (we couldn't do it in time).
jcsp
changed the title
jcsp
approved these changes
Nov 16, 2022
|
I amended the title to be a bit more succinct. Did you mean to mark this as |
|
I was looking into the failure of |
|
/backport v22.3.x |
This was referenced Nov 22, 2022
Closed
|
/backport v22.2.x |
This was referenced Nov 22, 2022
Closed
|
fyi i changed the release notes section of the pr body from |
|
/backport v22.1.x |
This was referenced Nov 24, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cover letter
When do_transfer_leadersip(), if a follower is still not caught up after prepare_transfer_leadership() is done, a
timeoutwas returned. However it's not really a timeout, it's a flap (we thought recovery was done but it's not). This commit changes it toexponential_backoffso that admin API would return a 503 (plz retry) for that rather thana 504 (we couldn't do it in time).
Fixes #6902
This not a fix for the root cause of the issue, only a change of interpretation of the error.
Backport Required
UX changes
Release notes
Improvements