Unevenness error stop condition improvements/fixes #7408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When update is finished the error should be reset so that the next update rebalancing is not influenced with the result of previous one. Signed-off-by: Michal Maslanka <michal@redpanda.com>
As the unevenness error is in the range of 0.0 to 1.0 we must use floating point to make calculations accurate. Signed-off-by: Michal Maslanka <michal@redpanda.com>
Signed-off-by: Michal Maslanka <michal@redpanda.com>
mmaslankaprv
force-pushed
the
last-unevenees-improvements
branch
from
7099602
to
f2d6b4d
Compare
VadimPlh
approved these changes
Nov 21, 2022
emaxerrno
reviewed
Nov 21, 2022
ztlpn
approved these changes
Nov 21, 2022
|
/backport v22.3.x |
|
Oops! Something went wrong. |
|
/backport v22.3.4 |
|
Failed to run cherry-pick command. I executed the below command: |
|
with the codebase currently in v22.3.x branch, backport of this PR causes conflicts. it seems like the conflicts can be avoided if PR #7388 is first backported to v22.3.x branch. backport attempted and created: PR #7416 |
|
/backport v22.3.4 |
|
fyi this PR seems like an improvement so i've added it as such in the PR body (it was blank before) |
|
Please backport to v22.2.x - https://buildkite.com/redpanda/redpanda/builds/27435#0187967e-8fba-485b-b8ef-ac14b71bd2c9 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improved handling of stop condition based on lack of partition balance improvement.
Backports Required
UX Changes
Release Notes
Improvements