rpk: encourage users to restart nodes on config change if required #7421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twmb
reviewed
Nov 22, 2022
daisukebe
force-pushed
the
rpk-encourage-restart
branch
from
d4b6925
to
e852e9c
Compare
daisukebe
commented
Nov 22, 2022
r-vasquez
reviewed
Nov 22, 2022
daisukebe
force-pushed
the
rpk-encourage-restart
branch
from
e852e9c
to
14dfd85
Compare
|
@daisukebe - can we packport this change to 22.2.x too |
r-vasquez
previously approved these changes
Nov 22, 2022
|
/backport v22.2.8 |
|
/backport v22.3.4 |
|
The pull request is not merged yet. Cancelling backport... |
|
The pull request is not merged yet. Cancelling backport... |
twmb
reviewed
Nov 24, 2022
daisukebe
force-pushed
the
rpk-encourage-restart
branch
from
14dfd85
to
0fdbea4
Compare
|
Fixed the failed test. |
daisukebe
force-pushed
the
rpk-encourage-restart
branch
from
0fdbea4
to
9955126
Compare
r-vasquez
approved these changes
Nov 25, 2022
|
Thanks ! @daisukebe |
|
/backport v22.2.x |
|
/backport v22.3.x |
This was referenced Nov 25, 2022
|
@daisukebe fyi i update the release notes section of the pr body |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7420
Backports Required
UX Changes
Upon completion of
rpk cluster config editorrpk cluster config set, print the following message if restart is required:Release Notes
Improvements
rpk cluster config editorrpk cluster config set, print the following message if restart is required: