features: remove consumer offset migration code + test #7507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Updated this to remove some of the enable/disable hooks on other subsystems that were only used by this migrator. Changed the definition of the consumer_offsets feature to no longer require preparing (this was causing test failures because consumer group code was never coming up) |
This is the migration path for <= 21.11.x clusters. This change will land in Redpanda 23.1, at which point upgrades from pre-22.1.x clusters will no longer support migrating consumer offsets topic.
This test could end up trying to use a decommed node's admin API to query the status of the cluster, and fail on too many 503s. Fixes redpanda-data#6721
This was only needed for consumer group migration logic, which has been removed.
This was only needed for consumer offsets migration code, which has now been removed.
This was the <= Redpanda 21.x precursor to consumer offsets topic, which we no longer use.
There is no longer a migrator: if we required migration it would never activate.
jcsp
force-pushed
the
remove-consumer-offsets-migration
branch
from
ba58d4e
to
f9d030b
Compare
|
lgtm, i will prepare a pr removing the Kafka bits used to handle old data format |
mmaslankaprv
approved these changes
Nov 28, 2022
|
🔥 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the data migration path for <= 21.11.x clusters.
This change will land in Redpanda 23.1, at which point
upgrades from pre-22.1.x clusters will no longer support
migrating consumer offsets topic.
There is probably other code that can be cleaned up after this that related
to the routing of group operations to either the old or new topic.
Backports Required
UX Changes
None
Release Notes
Improvements