Fixed finishing recommissioning update #7533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michal Maslanka <michal@redpanda.com>
mmaslankaprv
force-pushed
the
fix-7526
branch
from
164138b
to
94fb842
Compare
Fixed stop condition to allow recommissioning operations that do not require reallocations to finish. Previously the recommissioning operation would only finish if there were reallocations finished. Fixed the incorrect stop condition by finishing the recommission operation that does not require reallocations. Fixes: redpanda-data#7275 Signed-off-by: Michal Maslanka <michal@redpanda.com>
Added test validating that the cycle of decommission/recommission/decommission of a node is possible. Signed-off-by: Michal Maslanka <michal@redpanda.com>
mmaslankaprv
force-pushed
the
fix-7526
branch
from
94fb842
to
49812c2
Compare
|
@mmaslankaprv does it make sense to expose an admin api to get this unstuck in the future. something like, |
I will add an admin API that will allow us to force cancel ongoing re-balancing operation in a follow up PR |
|
@mmaslankaprv please don't forget the backports (and sorry if I missed seeing them) |
|
/backport v22.2.x |
|
/backport v22.3.x |
This was referenced Nov 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
c/members_backend: allow empty recommissioning updates to finish
Fixed stop condition to allow recommissioning operations that do not
require reallocations to finish. Previously the recommissioning
operation would only finish if there were reallocations finished. Fixed
the incorrect stop condition by finishing the recommission operation
that does not require reallocations.
Fixes: #7526
Backports Required
UX Changes
Release Notes
Bug Fixes