-
Notifications
You must be signed in to change notification settings - Fork 552
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kafka: update describe configs version #7543
kafka: update describe configs version #7543
Conversation
80390fe
to
0e814de
Compare
0e814de
to
15ff3eb
Compare
15ff3eb
to
9296d42
Compare
9296d42
to
0c539cb
Compare
From Kafka 3.3
7823436
to
11b5235
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
static_assert
needs a change probably otherwise LGTM
ee38f8c
to
bd39be6
Compare
CI Failures are due to tarball issue and #7788 is the patch for it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All of the changes in describe_configs.cc
look great, only comments are on the TMP magic, I think we're good to merge after those are in. Nice work !
bd39be6
to
16a0ad6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
16a0ad6
to
dc87280
Compare
dc87280
to
9f51c67
Compare
This commit includes a ducktape test that run DescribeConfigs on a topic with documentation and config type enabled.
9f51c67
to
d186c73
Compare
Cover letter
KIP-569 updated DescribeConfigs to include a
documentation
string andconfig type
enum in the response. Therefore this PR updates DescribeConfigs to the new API version with the new fields.Fixes #4170
Changes from force-push
0e814de
:int_type
for reserved keywordsbase_property.desc()
for the documentation textdescribe_config_type
. This is for theConfigType
field from KIP-569Changes from force-push
15ff3eb
:reflection::is_std_vector
model::compression
property_config_type
when the type is an optionalstd::nullopt
into the documentation field wheninclude_documentation
is unsetmake_documentation_string
lambda. Instead pass theinclude_documentation
option as an argumentChanges from force-push
9296d42
:typename T
std::optional<std::optional<T>>
to capture atristate<T>
std::optional
instead of plumbinginclude_documentation
Changes from force-push
0c539cb
:Changes from force-push
7823436
:property_config_type
intoproperty_config_type_by_type
andproperty_config_type_by_name
Changes from force-push
11b5235
:std::optional
totristate
in the tristate overload ofadd_topic_config
tristate
to final version ofadd_topic_config
Changes from force-push
ee38f8c
:Changes from force-push
bd39be6
:tristate<T> overrides
- this was causing DT tests to failint
Changes from force-push
16a0ad6
:constexpr
for typetraits instead of a monolith functionChanges from force-push
dc87280
:auto
instead ofint
fornum_bits
!is_bool<T>
to integral type traitsChanges from force-push
9f51c67
:!is_bool<T>
only for theis_short<T>
checkChanges from force-push
d186c73
:short <= 16bits
,16bits < int <= 32bits
,32bits < long <= 64bits
Backports Required
UX Changes
Release Notes
Improvements