Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rpk: add cluster txn commands #7557

Merged
merged 4 commits into from
Dec 7, 2023
Merged

rpk: add cluster txn commands #7557

merged 4 commits into from
Dec 7, 2023

Conversation

twmb
Copy link
Contributor

@twmb twmb commented Nov 29, 2022 •
edited
Loading

For #7308

UX Changes

Adds:

rpk cluster txn 
rpk cluster txn list
rpk cluster txn describe
rpk cluster txn describe-producers

Release Notes

Features

  • rpk now has a cluster txn command space

@twmb twmb requested review from 0x5d, r-vasquez and a team as code owners November 29, 2022 15:10
r-vasquez
r-vasquez reviewed Dec 1, 2022
View reviewed changes
src/go/rpk/pkg/cli/cmd/cluster/txn/txn.go Outdated Show resolved Hide resolved
src/go/rpk/pkg/cli/cmd/cluster/txn/txn.go Outdated Show resolved Hide resolved
src/go/rpk/pkg/cli/cmd/cluster/txn/abort.go Outdated Show resolved Hide resolved
src/go/rpk/pkg/cli/cmd/cluster/txn/txn.go Outdated Show resolved Hide resolved
src/go/rpk/pkg/cli/cmd/cluster/txn/abort.go Outdated Show resolved Hide resolved
src/go/rpk/pkg/cli/cmd/cluster/txn/abort.go Outdated Show resolved Hide resolved
src/go/rpk/pkg/cli/cmd/cluster/txn/describe.go Outdated Show resolved Hide resolved
src/go/rpk/pkg/cli/cmd/cluster/txn/describe_producers.go Outdated Show resolved Hide resolved
src/go/rpk/pkg/cli/cmd/cluster/txn/find_hanging.go Outdated Show resolved Hide resolved
src/go/rpk/pkg/cli/cmd/cluster/txn/find_hanging.go Outdated Show resolved Hide resolved
@twmb twmb force-pushed the rpk_txn branch 3 times, most recently from 706b64d to 9c8ed45 Compare December 14, 2022 02:13
r-vasquez
r-vasquez previously approved these changes Dec 14, 2022
View reviewed changes
Copy link
Contributor

@r-vasquez r-vasquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@joejulian
Copy link
Contributor

needs rebase

@vshtokman vshtokman mentioned this pull request Apr 11, 2023
Closed
joejulian
joejulian previously requested changes Jun 5, 2023
View reviewed changes
Copy link
Contributor

@joejulian joejulian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove src/go/k8s changes.

@joejulian joejulian removed the area/k8s label Jun 5, 2023
@twmb twmb requested a review from gene-redpanda as a code owner July 7, 2023 16:02
@twmb twmb dismissed joejulian’s stale review July 7, 2023 16:02

k8s dropped.

@twmb twmb removed the needs rebase label Jul 7, 2023
@twmb
Copy link
Contributor Author

twmb commented Jul 7, 2023

Blocked on:
#11949
#11948
#11947

@twmb twmb added the blocked label Jul 7, 2023
@twmb
rpk/out: add StructFields function
6b64175 
This splits StructFields from PrintStructFields, making it easier to
have the same compile-time-type-checking benefit that PrintStructFields
provides in other locations.
@twmb twmb force-pushed the rpk_txn branch 2 times, most recently from 2a90715 to 865ca0d Compare November 7, 2023 19:29
@vbotbuildovich
Copy link
Collaborator

ducktape was retried in job https://buildkite.com/redpanda/redpanda/builds/40632#018bab6d-f404-4efc-a0ab-ee5118a28e46

@vbotbuildovich
Copy link
Collaborator

vbotbuildovich commented Nov 28, 2023 •
edited
Loading

new failures in https://buildkite.com/redpanda/redpanda/builds/41820#018c13a2-6de4-4301-bf2e-0058aa0bc616:

"rptest.tests.topic_delete_test.TopicDeleteCloudStorageTest.topic_delete_unavailable_test.cloud_storage_type=CloudStorageType.S3"

new failures in https://buildkite.com/redpanda/redpanda/builds/42307#018c3d30-e565-438a-8a07-e4ed2cbb3e99:

"rptest.tests.consumer_offsets_consistency_test.ConsumerOffsetsConsistencyTest.test_flipping_leadership"

@vbotbuildovich
Copy link
Collaborator

ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/41820#018c13a2-6de1-4d37-a9e5-95de925fd486

@twmb twmb force-pushed the rpk_txn branch 2 times, most recently from 342bc04 to 2e6a0b3 Compare November 30, 2023 19:57
@twmb @r-vasquez
rpk: add 'cluster txn' commands
16c8c2e 
Added:

rpk cluster txn
rpk cluster txn list
rpk cluster txn describe
rpk cluster txn describe-producers

For redpanda-data#7308.
@r-vasquez
rpk txn: add --format json flag support to txn
328bc89
@r-vasquez
tests: add tests for rpk cluster txn
54d0d62 
This is a copy of the transaction_kafka_api_test.py
but using rpk instead of the kafka_cli tool.
@r-vasquez r-vasquez removed the blocked label Dec 6, 2023
@r-vasquez
Copy link
Contributor

/ci-repeat 5
skip-units
dt-repeat=10
tests/rptest/tests/rpk_transaction_test.py

twmb
twmb commented Dec 7, 2023
View reviewed changes
Copy link
Contributor Author

@twmb twmb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent, +1.

src/go/rpk/pkg/cli/cluster/txn/describe_producers.go
Comment on lines +105 to +107
if len(d.ActiveProducers) == 0 {
continue
}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: unnecessary conditional

gene-redpanda
gene-redpanda approved these changes Dec 7, 2023
View reviewed changes
Copy link
Contributor

@gene-redpanda gene-redpanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@twmb twmb merged commit 40e6cad into redpanda-data:dev Dec 7, 2023
24 checks passed
@twmb twmb deleted the rpk_txn branch December 7, 2023 14:56
@github-actions github-actions bot mentioned this pull request Dec 22, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gene-redpanda gene-redpanda gene-redpanda approved these changes

@joejulian joejulian joejulian left review comments

@r-vasquez r-vasquez r-vasquez left review comments

@0x5d 0x5d Awaiting requested review from 0x5d

Assignees
No one assigned
Labels
area/rpk
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@twmb @joejulian @vbotbuildovich @r-vasquez @gene-redpanda