Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kafka: report default-matching SI topic properties as DEFAULT_CONFIG #7602

Merged
merged 1 commit into from
Dec 8, 2022
Merged

kafka: report default-matching SI topic properties as DEFAULT_CONFIG #7602

merged 1 commit into from
Dec 8, 2022

Conversation

jcsp
Copy link
Contributor

@jcsp jcsp commented Dec 1, 2022

This is not semantically accurate, but some tooling does not accept properties that are permanently in DYNAMIC_TOPIC_CONFIG.

This enables such tools to cope with our tiered storage properties as long as they match the defaults.

Fixes #7451

Backports Required

  • none - not a bug fix
  • none - issue does not exist in previous branches
  • none - papercut/not impactful enough to backport
  • v22.3.x
  • v22.2.x
  • v22.1.x

UX Changes

None

Release Notes

Improvements

  • Improved compatibility with tools using AlterConfigs API. Tiered storage topic properties now report DEFAULT_CONFIG state if their current value matches the cluster defaults.

@jcsp
kafka: report default-matching SI topic properties as DEFAULT_CONFIG
7acb85f 
This is not semantically accurate, but some tooling does not
accept properties that are permanently in DYNAMIC_TOPIC_CONFIG.

This enables such tools to cope with our tiered storage properties
as long as they match the defaults.

Fixes redpanda-data#7451
@jcsp jcsp added kind/bug Something isn't working area/cloud-storage Shadow indexing subsystem labels Dec 1, 2022
@jcsp jcsp marked this pull request as ready for review December 2, 2022 09:32
@jcsp
Copy link
Contributor Author

jcsp commented Dec 6, 2022

This straddled the time when the parallel ducktape change merged, so ended up with apparent stuck jobs: its test run is actually 🟢 https://buildkite.com/redpanda/redpanda/builds/19363#_

@jcsp jcsp requested review from Lazin and removed request for mmaslankaprv December 6, 2022 14:14
Lazin
Lazin approved these changes Dec 8, 2022
View reviewed changes
Copy link
Contributor

@Lazin Lazin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jcsp jcsp merged commit f50c088 into redpanda-data:dev Dec 8, 2022
@jcsp jcsp deleted the issue-7451-si-default-configs branch December 8, 2022 15:59
@jcsp
Copy link
Contributor Author

jcsp commented Dec 8, 2022

/backport v22.3.x

This was referenced Dec 8, 2022
Closed
Merged
@jcsp jcsp mentioned this pull request Dec 12, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lazin Lazin Lazin approved these changes

@VladLazar VladLazar Awaiting requested review from VladLazar

Assignees
No one assigned
Labels
area/cloud-storage Shadow indexing subsystem area/redpanda kind/bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cloud_storage: tools that use AlterConfigs expect redpanda.remote.* configs to report DEFAULT_CONFIG
2 participants
@jcsp @Lazin