Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metadata viewer consumer offsets support #7603

Conversation

mmaslankaprv
Copy link
Member

@mmaslankaprv mmaslankaprv commented Dec 2, 2022

Added ability to read and decode __consumer_offsets topic to metadata viewer.

Backports Required

  • none - not a bug fix
  • none - issue does not exist in previous branches
  • none - papercut/not impactful enough to backport
  • v22.3.x
  • v22.2.x
  • v22.1.x

UX Changes

Release Notes

Improvements

  • added reading consumer offsets topic capability to Redpanda offline log viewer tool

@mmaslankaprv mmaslankaprv requested a review from a team as a code owner December 2, 2022 07:04
@mmaslankaprv mmaslankaprv requested review from nk-87, ztlpn, a team, daisukebe and dotnwat and removed request for a team December 2, 2022 07:04
daisukebe
daisukebe previously approved these changes Dec 2, 2022
Copy link
Contributor

@daisukebe daisukebe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me. It works without failure for a __consumer_offsets dir in a wild.

@mmaslankaprv mmaslankaprv force-pushed the metadata-viewer-consumer-offsets-support branch from d91ace8 to 6e50aa2 Compare December 2, 2022 12:40
@mmaslankaprv mmaslankaprv force-pushed the metadata-viewer-consumer-offsets-support branch 2 times, most recently from f0dac10 to 321a60d Compare December 20, 2022 10:05
@mmaslankaprv mmaslankaprv force-pushed the metadata-viewer-consumer-offsets-support branch from 321a60d to 31a71f6 Compare December 20, 2022 10:15
@mmaslankaprv mmaslankaprv force-pushed the metadata-viewer-consumer-offsets-support branch from 31a71f6 to fae4cc3 Compare December 20, 2022 15:51
@dotnwat
Copy link
Member

dotnwat commented Dec 25, 2022

/ci-repeat 1

@piyushredpanda piyushredpanda added this to the ST.drop milestone Dec 26, 2022
@piyushredpanda
Copy link
Contributor

@mmaslankaprv : please drive merging and backport to v22.3 so we can include in minor release on 6th.

jcsp
jcsp previously approved these changes Jan 3, 2023
graphcareful
graphcareful previously approved these changes Jan 3, 2023
tools/offline_log_viewer/consumer_offsets.py Outdated Show resolved Hide resolved
Signed-off-by: Michal Maslanka <michal@redpanda.com>
Signed-off-by: Michal Maslanka <michal@redpanda.com>
Signed-off-by: Michal Maslanka <michal@redpanda.com>
Signed-off-by: Michal Maslanka <michal@redpanda.com>
@mmaslankaprv mmaslankaprv dismissed stale reviews from graphcareful and jcsp via d7d49aa January 3, 2023 20:24
@mmaslankaprv mmaslankaprv force-pushed the metadata-viewer-consumer-offsets-support branch from fae4cc3 to d7d49aa Compare January 3, 2023 20:24
@mmaslankaprv mmaslankaprv merged commit 84b45c8 into redpanda-data:dev Jan 4, 2023
dotnwat added a commit that referenced this pull request Jan 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants