Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ducktape: Change diff for connection_rate_test #7648

Merged
merged 1 commit into from
Dec 15, 2022

Conversation

VadimPlh
Copy link
Contributor

@VadimPlh VadimPlh commented Dec 7, 2022

Overview

Connection rate limit test uses constant diff to compare 2 difference times.
This constant was was chosen randomly.

After several month of testing this test failed once on CDT.
The diff between times in this case was 1.65.

So we can adjust expected diff for test and decrease it to 1.6

Fixes #7288

Backports Required

  • none - not a bug fix
  • none - issue does not exist in previous branches
  • none - papercut/not impactful enough to backport
  • v22.3.x
  • v22.2.x
  • v22.1.x

UX Changes

Release Notes

Improvements

  • Fix const in connection_rate_limit_test

This const is random number. After several
months of testing test failed first time
on CDT. But second time was around 1.65 *
first_time.

So this limit has to be fix a little bit
@VadimPlh VadimPlh marked this pull request as ready for review December 7, 2022 13:05
@VadimPlh VadimPlh requested review from dotnwat and jcsp December 7, 2022 13:06
@jcsp jcsp merged commit 1475d88 into redpanda-data:dev Dec 15, 2022
@VadimPlh
Copy link
Contributor Author

/backport v22.3.x

@VadimPlh
Copy link
Contributor Author

/backport v22.2.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FAIL test: ConnectionRateLimitTest.connection_rate_test
2 participants