cluster: initialize node ID assignment counter #7821
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
The counter isn't currently initialized with any of the node IDs that are assigned to seed servers. This can result in a seed server's node ID being reused after it's been decommissioned. This commit adds a layer of protection by initializing the node ID counter to just past the highest assigned node ID. I updated some of the existing tests with a stricter check that would have caught this issue. Another approach to protect this case is to check the removed set of nodes when assigning a node ID. A separate change will add that.
This commit adds a test that wipes and restarts a cluster one node at a time in sequence with a workload running, leveraging the new features that enable homogeneous node configuration.
andrwng
force-pushed
the
initialize-seed-node-ids
branch
from
a83dfce
to
0f3438c
Compare
|
@andrwng nevermind. i was clicking on the |
mmaslankaprv
approved these changes
Dec 19, 2022
|
/backport v22.3.x |
|
Failed to run cherry-pick command. I executed the below command: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We previously weren't initializing the node ID assignment counter with the node IDs assigned to the cluster founders. This PR bumps the counter with the node IDs available at initial cluster bootstrap. This fix is adjacent to the one in #7789 -- it's just another layer of protection.
This PR also adds a test that restacks a cluster in random order, ensuring that no node IDs are reused, which would have caught this issue.
Backports Required
UX Changes
Release Notes
Bug Fixes