Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

k8s: Fix wrong WithValues invocation #7828

Merged
merged 1 commit into from
Dec 19, 2022

Conversation

RafalKorepta
Copy link
Contributor

The WithValues requires to have pairs of key and value fileds for logger to report any additional context.

Fixes #7818

Backports Required

  • none - not a bug fix
  • none - issue does not exist in previous branches
  • none - papercut/not impactful enough to backport
  • v22.3.x
  • v22.2.x
  • v22.1.x

Release Notes

Bug Fixes

  • Fix operator panic during decommissioning logging

The `WithValues` requires to have pairs of key and value fileds for logger
to report any additional context.
@RafalKorepta RafalKorepta requested a review from a team as a code owner December 19, 2022 10:46
@RafalKorepta
Copy link
Contributor Author

Hitting not related error:

test_id:    rptest.tests.nodes_decommissioning_test.NodesDecommissioningTest.test_multiple_decommissions
--
  | status:     FAIL
  | run time:   2 minutes 10.035 seconds
  |  
  |  
  | TimeoutError('')
  | Traceback (most recent call last):
  | File "/usr/local/lib/python3.10/dist-packages/ducktape/tests/runner_client.py", line 135, in run
  | data = self.run_test()
  | File "/usr/local/lib/python3.10/dist-packages/ducktape/tests/runner_client.py", line 227, in run_test
  | return self.test_context.function(self.test)
  | File "/root/tests/rptest/services/cluster.py", line 35, in wrapped
  | r = f(self, *args, **kwargs)
  | File "/root/tests/rptest/tests/nodes_decommissioning_test.py", line 471, in test_multiple_decommissions
  | wait_until(lambda: self._partitions_moving(),
  | File "/usr/local/lib/python3.10/dist-packages/ducktape/utils/util.py", line 57, in wait_until
  | raise TimeoutError(err_msg() if callable(err_msg) else err_msg) from last_exception
  | ducktape.errors.TimeoutError

https://buildkite.com/redpanda/redpanda/builds/19980#01852a1b-7abc-4f14-bf21-eea4854834b5/6-2747

@RafalKorepta RafalKorepta merged commit 5eb78c8 into redpanda-data:dev Dec 19, 2022
@RafalKorepta
Copy link
Contributor Author

/backport v22.3.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Operator: wrong usage of logr WithValues makes operator panic
3 participants