kafka: fix handling redpanda.remote.delete in AlterConfigs #7922
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcsp
added
kind/bug
This was being matched, but a missing `continue` meant we fell through to the unmatched error path. Fixes redpanda-data#7921
...and raise exceptions on when it fails. This is a deprecated API but we still need to test it, and fortunately KCL still includes it.
jcsp
force-pushed
the
issue-7921-alter-config
branch
from
910712b
to
b6c8ad3
Compare
|
CI failure is #7874 |
mmaslankaprv
approved these changes
Dec 23, 2022
|
/backport v22.3.x |
This was referenced Dec 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was being matched, but a missing
continuemeant we fell through to the unmatched error path.Fixes #7921
Backports Required
UX Changes
Release Notes
Bug Fixes
redpanda.remote.deletetopic property via the legacy AlterConfig API (this API was deprecated in Kafka 2.3.0, but is supported for backward compatibility)