rpk: handle duration in offset range properly #7971
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daisukebe
force-pushed
the
handle-duration-in-offset
branch
3 times, most recently
from
410ec2f
to
bf66adf
Compare
daisukebe
force-pushed
the
handle-duration-in-offset
branch
from
bf66adf
to
f61f767
Compare
twmb
approved these changes
Jan 6, 2023
|
The build error is unrelated? |
|
Yes, looks like #7803 repeatedly. Going to run one more time, otherwise I'll ping @piyushredpanda to merge. |
|
/backport v22.3.x |
|
/backport v22.2.x |
This was referenced Jan 10, 2023
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves
consume.goto handle scenarios when an offset range inrpk topic consumecontains durations, e.g.,1h,24h, or-48h, properly.@2022-02-14T01:01:01Z:1hparseConsumeTimestampparses the first half, start offset, it setsfromTimestamptotrueas long as the first half is a given date formatparseConsumeTimestampis called to parse the second half, end offset, it adds a 1 hour duration sincestartAtconsume_test.goto test ifparseConsumeTimestampparses different types of offset range properlyFixes #7691
Backports Required
Release Notes
Bug Fixes
--offsetoption parses duration properly, e.g.--offset @2022-02-14:1h