Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: add test of pandaproxy mTLS with urllib #8022

Merged
merged 1 commit into from
Jan 10, 2023

Conversation

jcsp
Copy link
Contributor

@jcsp jcsp commented Jan 4, 2023

Reproduces #8020

This test should start to pass once https://github.com/redpanda-data/vtools/pull/1295 is merged.

The release notes section describes the fix, as the actual fix is buried in a vtools commit and seastar commit.

Backports Required

This bug was worked around separately in v22.3.x by reverting the seastar change that fixed case sensitivity in parsing of Connection headers. Given the general fragility of this area, I'm leaving that workaround in place rather than trying to backport the true fix.

  • none - not a bug fix
  • none - issue does not exist in previous branches
  • none - papercut/not impactful enough to backport
  • v22.3.x
  • v22.2.x
  • v22.1.x

UX Changes

None

Release Notes

Bug Fixes

  • https:// clients which send a "Connection: none" header over a TLS connection no longer experience premature connection closure.

@jcsp jcsp marked this pull request as ready for review January 9, 2023 15:01
@jcsp
Copy link
Contributor Author

jcsp commented Jan 9, 2023

Rebuilding to pick up merge of the vtools dependency

@jcsp
Copy link
Contributor Author

jcsp commented Jan 9, 2023

/ci-repeat 1 dt-repeat=50 skip-unit tests/rptest/tests/pandaproxy_test.py::PandaProxyMTLSTest.test_mtls_urllib

@jcsp
Copy link
Contributor Author

jcsp commented Jan 9, 2023

CI clean on first run, giving the new test some repeats.

@jcsp
Copy link
Contributor Author

jcsp commented Jan 9, 2023

/ci-repeat 5 dt-repeat=5 skip-unit tests/rptest/tests/pandaproxy_test.py::PandaProxyMTLSTest.test_mtls_urllib

@jcsp
Copy link
Contributor Author

jcsp commented Jan 9, 2023

That previous run had some cluster join timeout failures in setUp, which this PR doesn't change at all. I suspect it was because I ran with such wideparallelism and a bunch of identical tests were all trying to start up concurrently, upsetting oversubscribed cores on the test runner. Let's try a bunch of repeats on distinct test runners...

Copy link
Contributor

@NyaliaLui NyaliaLui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me once CI is green.

@dotnwat dotnwat merged commit a014ec6 into redpanda-data:dev Jan 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants