k8s: broker_tls is enabled only if internal listener has tls

[alenkacz]

currently we set broker_tls to enabled even if internal listener does not have tls.

broker_tls:
        enabled: true

Backports Required

• none - not a bug fix
• none - issue does not exist in previous branches
• none - papercut/not impactful enough to backport
• v22.3.x
• v22.2.x
• v22.1.x

UX Changes

None

Release Notes

Bug Fixes

• Fix for unreleased feature Allow pandaproxy and schemaregistry to connect to kafka api over tls #7820

[BenPope]

I don't know the code very well, but perhaps:

Suggested change

	result.internalTlsEnabled = true
	tls = internalTLSListener.GetTLS()
	if tls != nil {
	result.internalTlsEnabled = tls.Enabled
	}

[alenkacz]

func getInternalTLSListener(listeners []APIListener) APIListener {
	tlsListeners := getTLSListeners(listeners)
	for _, l := range tlsListeners {
		if ext := l.GetExternal(); ext == nil || !ext.Enabled {
			return l
		}
	}
	return nil
}

func getTLSListeners(listeners []APIListener) []APIListener {
	res := []APIListener{}
	for i, el := range listeners {
		tlsConfig := el.GetTLS()
		if tlsConfig != nil && tlsConfig.Enabled {
			res = append(res, listeners[i])
		}
	}
	return res
}

it's already handled here

[alenkacz]

/backport v22.3.x